Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance limb healing functionality #55069

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented Feb 3, 2022

Summary

None

Purpose of change

Limbs need some more options to mess with their healing.

Describe the solution

  • Modified the BP healing logic slightly to only run when the healed amount would be different from 0
  • Added two new bodypart flags: HEAL_OVERRIDE replaces the healing step of the limb with the bodypart's heal_bonus, while ALWAYS_HEAL triggers the bonus on every regen roll not just successful ones

Describe alternatives you've considered

Not mess with the logic, but it kind of messed with what I intended a negative heal_bonus to be (and running that whole thing every five minutes for every BP felt a bit...messy).

Testing

Tried all combos: Base healing is unchanged, Debug Tail heals up fast (heal_bonus of 15, no flag changes), with ALWAYS_HEAL it's up to full health in 10 minutes, with HEAL_OVERRIDE on top minimally slower.

Additional context

This should be useful for e.g. bionic/prosthetic limbs that don't heal and makes "wasting" limbs less of a gutpunch.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 3, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 3, 2022
@Maleclypse Maleclypse added Limbs Limbs, mutable limbs, and code related to them. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs labels Feb 3, 2022
@kevingranade kevingranade merged commit c6e58fc into CleverRaven:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Limbs Limbs, mutable limbs, and code related to them. [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants