Make Clang 6 the basic build test configuration #55059
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
The
Clang 6, Ubuntu, Curses
configuration compiles and links much faster thanGCC 9 LTO
, and tests also finish quicker than theGCC 9 LTO
workflow.Sample 1: https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/1739045814
(crafting_skill_gain)
(~[slow] ~[.])
([slow] ~crafting_skill_gain)
Sample 2: https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/1786607218
(crafting_skill_gain)
(~[slow] ~[.])
([slow] ~crafting_skill_gain)
In a full cache hit scenario, GCC 9 LTO workflow takes 20-30 minutes, while Clang 6 workflow can complete around 10 minutes. It is attractive to make Clang 6 the basic build test configuration.
Describe the solution
Shuffle
matrix.yml
, move Clang 6 to the front and rename its title to Basic Build Test. Repository branch protection rules also need to be updated to make the new title the required test.Describe alternatives you've considered
Testing
Additional context