-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pants and leg armor to class #55057
Added pants and leg armor to class #55057
Conversation
Automatic Rifleman class for CRT mod was missing pants
Hey @Zireael07, I have seen you around a few times, do you know anything about submitting a fix? |
The fix looks ok, it even got a green tick on first try. For the rest of the CI tests, you will need a maintainer to come by and allow them to run. Just be patient. |
Perfect! Thank you very much for confirming, I shall now wait. |
I approved the run of the tests, please fix your PR summary though: https://github.com/CleverRaven/Cataclysm-DDA/blob/master/.github/CONTRIBUTING.md#all-prs-should-have-a-summary-section-with-one-line Also add a closing keyword: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
Thanks for the info @NetSysFire! |
I noticed that one of the tests failed, giving the error "Error: Process completed with exit code 1." |
There are currently no failed tests. They may sometimes fail literally randomly because of the random seed. In this case it has nothing to do with your change. There is nothing you need to do here except wait for it to get merged. |
Summary
Mods "Added CRT pants and CRT leg guard to class 'Automatic Rifleman'"
Purpose of change
The class was missing pants and armor
Describe the solution
I added the pants and armor into the JSON file
Testing
I made the changes to the JSON file to my game, and loaded the mod, then chose the class, to see that the pants and armor were added.
EDIT:
I have now built the game with my changes implemented, and the class now has pants and leg guards.
Shown here:
closes #55043