Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pants and leg armor to class #55057

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

KeaneCarotenuto
Copy link
Contributor

@KeaneCarotenuto KeaneCarotenuto commented Feb 3, 2022

Summary

Mods "Added CRT pants and CRT leg guard to class 'Automatic Rifleman'"

Purpose of change

The class was missing pants and armor

Describe the solution

I added the pants and armor into the JSON file

Testing

I made the changes to the JSON file to my game, and loaded the mod, then chose the class, to see that the pants and armor were added.
EDIT:
I have now built the game with my changes implemented, and the class now has pants and leg guards.
Shown here:
image

closes #55043

Automatic Rifleman class for CRT mod was missing pants
@KeaneCarotenuto
Copy link
Contributor Author

Hey @Zireael07, I have seen you around a few times, do you know anything about submitting a fix?
I'm not entirely sure if I have done this right, or if there is more I need to do.

@Zireael07
Copy link
Contributor

The fix looks ok, it even got a green tick on first try.

For the rest of the CI tests, you will need a maintainer to come by and allow them to run. Just be patient.

@KeaneCarotenuto
Copy link
Contributor Author

Perfect! Thank you very much for confirming, I shall now wait.

@NetSysFire NetSysFire added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods: CRIT Anything to do with the CRIT mod Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Feb 3, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 3, 2022
@KeaneCarotenuto
Copy link
Contributor Author

Thanks for the info @NetSysFire!
I have changed my summary to be one line, like the examples given, and added the closes key word to the end.

@KeaneCarotenuto
Copy link
Contributor Author

I noticed that one of the tests failed, giving the error "Error: Process completed with exit code 1."
Is this something to worry about?

@NetSysFire
Copy link
Member

I noticed that one of the tests failed, giving the error "Error: Process completed with exit code 1."
Is this something to worry about?

There are currently no failed tests. They may sometimes fail literally randomly because of the random seed. In this case it has nothing to do with your change.

There is nothing you need to do here except wait for it to get merged.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 4, 2022
@Rivet-the-Zombie Rivet-the-Zombie merged commit 9fb7080 into CleverRaven:master Feb 4, 2022
@KeaneCarotenuto KeaneCarotenuto deleted the #55043_Pants branch February 4, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: CRIT Anything to do with the CRIT mod Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRIT Expansion Mod: CRIT Automatic Rifleman Profession starts without pants
5 participants