Fix crash in armor coverage test #55037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix crash in armor coverage test"
Purpose of change
Tests have been consistently crashing on MinGW recently, and also crashes randomly in GCC 9 Linux configuration.
Describe the solution
The test case spawns two test NPCs, one of them overlaps with avatar character, causing very weird behaviors in projectile attack and damage handling code. This pull request shifts the position of test creatures by 4 tiles and seemingly solves the crash.
Describe alternatives you've considered
Testing
Wait for general build matrix to pass on all build configurations.
Additional context