Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bō to weapons #55033

Merged

Conversation

VarrenKrytor
Copy link
Contributor

@VarrenKrytor VarrenKrytor commented Feb 2, 2022

Summary

Balance "Adds the Bō and nerfs Quarterstaff and it's related weapons"

Purpose of change

With all Quarterstaff weapons becoming non-durable and being seen as more of a stick that you carved, I wanted to introduce a proper weapon in this category: the bō. It's much harder to make and takes more time, but it retains the stats from the original Quarterstaff. I also nerf the Quarterstaff and it's related weapons by putting their 'balance' to neutral since they are not crafted with skill and would not be well balanced.

Describe the solution

Create a recipe that gives the players the ability to make a well crafted and traditionally used quarterstaff, the bō. Nerfs quarterstaffs further to be more in line with a stick hastily carved into a staff. The end result is a bō that functions exactly like the old quarterstaff, with much harsher crafting requirements. From my reading on the matter (and personal usage of a bō) this should be realistic.

Also updated descriptions of all quarterstaffs and the ability to use the bō for training purposes.

Describe alternatives you've considered

Leaving things as they are. But with the quarterstaff nerfs my updated descriptions should probably be kept at the very least, and maybe even my nerf to their to_hit since they would no longer be well-balanced.

Testing

Tested and working

Additional context

This is my first weapon addition, critique it harshly. Currently failing tests that don't seem to be related. Probably needs to be re-run.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 2, 2022
@Dandy-boy
Copy link

For the Bō's description, you should add a period to the end and change that "finally" to "finely" (i assume this was just a typo).

@Maleclypse Maleclypse added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Feb 3, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 3, 2022
@VarrenKrytor
Copy link
Contributor Author

Tested and working.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 3, 2022
@CosmicHitman
Copy link
Contributor

The quarterstaff has the rapid strikes technique but the bo staff does not. Is this intended? (this is not a critique, just a double check)

@VarrenKrytor
Copy link
Contributor Author

VarrenKrytor commented Feb 4, 2022

This is intended. As someone who has used the Bo, it doesn't really swing quicker like a dagger might. You could argue that a poking attack was faster, but you still need to pull back a decent amount to do any damage. It's also heavier than it might look. With the new quarterstaff changes and being made out of essentially a large branch, I would imagine it could be used quicker at the cost of not being very durable.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants