Give a chance of another try if game is unable to find a valid starting location

[Night-Pryanik]

Summary

Features "Give a chance of another try if game is unable to find a valid starting location."

Purpose of change

• Quality of life stuff for Unable to generate a valid starting location #35376. It doesn't fix the issue.

Describe the solution

On unsuccessful attempt of finding a valid starting location, query player if he wants to give it another try. On positive answer reset the world and make another attempt of finding a valid starting location.

Describe alternatives you've considered

None.

Testing

Reduced chance to spawn for one of locations so it has a fairly high chance of fail to find a suitable location, made several attempts of starting a game. Answered both yes and no to the query, checked that game correctly resets world and tries to find valid starting location once more.

Additional context

As I said earlier, this PR doesn't fix the issue because player could adjust settings of the world (in particular, sizes of cities) so game won't ever find a valid starting location. Player might not even know that selected location has conditions/constraints to spawn as they are hidden in jsons and ain't shown to the player in game. I think we need to track down these cases and at least notify player that his starting location won't ever spawn on his current world settings.

[NetSysFire]

This change looks good overall but there might be a disaster waiting to happen because it is that trivial to accidentally reset the world. Perhaps check if there is more than one save in the world and make the warning a bit bolder?

"This will delete all savegames! Are you sure?"

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• Try again? Warning: all savegames in current world will be deleted!\n\nIt may require several attempts until the game finds a valid starting location.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

[Night-Pryanik]

I don't know, I think it's equally easy to accidentally reset the world even if there would be a "ARE YOU SURE?" type of warning.

After all, ideally this query should appear on very rare occasion, not on everyday basis, so I think it would catch player's attention.

[Zireael07]

Player might not even know that selected location has conditions/constraints to spawn as they are hidden in jsons and ain't shown to the player in game. I think we need to track down these cases and at least notify player that his starting location won't ever spawn on his current world settings.

Is there a way for devs to detect it programmatically or would it need to be audited by hand like the start difficulty entry?

[Night-Pryanik]

Is there a way for devs to detect it programmatically

Sure. For example, check for city_sizes and city_distance fields in json definitions of OM specials.