Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanics Practice recipes #55010

Merged

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Feb 2, 2022

Summary

Content "Mechanics practice recipes"

Purpose of change

Adds early mechanics practice recipes.

Describe the solution

Adds recipes, tools, and manuals for mechanics practice recipes. Based them off of STEM kits for teens and adults.

Describe alternatives you've considered

none

Testing

Tested and they spawn. All recipes work. The xp gain which is set outside of practice recipes is through the roof but that's beyond the scope of this PR.

Additional context

@Maleclypse Maleclypse added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map Items / Item Actions / Item Qualities Items and how they work and interact Mechanics: Effects / Skills / Stats Effects / Skills / Stats labels Feb 2, 2022
@Maleclypse Maleclypse marked this pull request as draft February 2, 2022 03:52
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 2, 2022
@Maleclypse Maleclypse force-pushed the Stem-Kits-for-mechanics-practice branch from 2bd7f9e to ad47662 Compare February 2, 2022 04:03
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Practice basic mechanics by using a pre-cataclysm educatainment set. Learn about hydraulics.
  • Practice basic mechanics by using a pre-cataclysm edutainment set. Learn about engines.
  • Practice basic mechanics by using a pre-cataclysm edutainment set. Learn about robots.
  • copies of makerspace kit instructions
  • makerspace kit for STEM
  • makerspace kit for STEMs
  • makerspace kit instructions
  • robotics kit for young learnerss

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Maleclypse Maleclypse force-pushed the Stem-Kits-for-mechanics-practice branch 2 times, most recently from e86cda0 to 8378175 Compare February 2, 2022 04:49
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Practice basic mechanics by using a pre-cataclysm edutainment set. Learn about engines.
  • Practice basic mechanics by using a pre-cataclysm edutainment set. Learn about hydraulics.
  • Practice basic mechanics by using a pre-cataclysm edutainment set. Learn about robots.
  • copies of makerspace kit instructions
  • makerspace kit for STEM
  • makerspace kit for STEMs
  • makerspace kit instructions
  • robotics kit for young learnerss

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Maleclypse Maleclypse force-pushed the Stem-Kits-for-mechanics-practice branch 3 times, most recently from 82fcbfd to 824a4a4 Compare February 2, 2022 06:02
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Practice basic mechanics by using a pre-cataclysm edutainment set. Learn about engines.
  • Practice basic mechanics by using a pre-cataclysm edutainment set. Learn about hydraulics.
  • Practice basic mechanics by using a pre-cataclysm edutainment set. Learn about robots.
  • copies of makerspace kit instructions
  • makerspace kit for STEM
  • makerspace kit instructions
  • makerspace kits for STEM

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Update mechanics.json

spawns

Update mechanics.json

fixes

Update recipe_vehicle.json

Update science.json

fixes
@Maleclypse Maleclypse force-pushed the Stem-Kits-for-mechanics-practice branch from 824a4a4 to b5e8454 Compare February 2, 2022 06:08
@Maleclypse Maleclypse marked this pull request as ready for review February 2, 2022 06:47
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 2, 2022
@wapcaplet
Copy link
Contributor

wapcaplet commented Feb 3, 2022

The xp gain which is set outside of practice recipes is through the roof but that's beyond the scope of this PR.

Yeah, that's a known issue apparently affecting all recipes (just especially noticeable with practice recipes): #54708

Wonderful to see some mechanics practice recipes at last. I once had half a mind to add some Lego Mindstorms or Erector sets for the purpose, but your maker kits are more plausible as a learning tool. Nice work!

@kevingranade kevingranade merged commit 3a30331 into CleverRaven:master Feb 3, 2022
@NetSysFire NetSysFire added the [JSON] Changes (can be) made in JSON label Feb 4, 2022
@Maleclypse Maleclypse deleted the Stem-Kits-for-mechanics-practice branch September 24, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Effects / Skills / Stats Effects / Skills / Stats Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants