Aligns mutation.cpp with other uses of condition.cpp #55004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the Character pointer passed to condition.cpp non-constant, aligned with effect_on_condition.cpp. This fixes cases of condition triggered mutations being unable to use all conditions.
github-actions
bot
added
json-styled
Maleclypse
added
[C++]
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Triggered mutations can now use more (all?) conditions"
Purpose of change
This fixes cases of condition triggered mutations being unable to use all conditions. I noticed this while working on changes to the Alpha mutations.
Describe the solution
Makes the Character pointer passed to condition.cpp non-constant, aligned with effect_on_condition.cpp.
Describe alternatives you've considered
Testing
Was able to reliably trigger mutations based on conditions that did not work before, notably "vitamin".
Additional context