Clarify Trader Refresh Code #54996
Merged
Clarify Trader Refresh Code #54996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
json-styled
Maleclypse
added
[C++]
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Trader code was confusing. I spent a while debugging it because the logic wasn't obvious. Since it splits the week delay to refresh over a conditional and an increment.
Describe the solution
Now it just adds 6_days to the current turn as "restock" and tests if current turn - restock is > 0 (It's been more than 6 days)
Describe alternatives you've considered
This is a bit pedantic so I could leave it alone but I think having a comment and clearer numbers would be a boon.
Testing
Additional context