Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Gun Mods can override cycle recoil and more robustly change ammo type"
Purpose of change
more changes focused for #54723
Gun conversions (since they are barely used) don't have a lot of new gun system stuff.
Specifically I needed to be able to overload the min cycle recoil,
and
I needed to be able to have a default ammo (for UI purposes) that isn't a default ammo available in the default mag of the gun. Without this if you have a gun that takes multiple mag types with different ammo types and then the convert it to fire a different ammo type than the ammo of the first mag it nulls out.
Describe the solution
Revived some commented out code for magazine_default to let it consider conversions. This was already there and commented out in the function def. So I set the default to false (since the rest of the calls don't need it so it would be wasted execution). And in the relevant call set it to true.
Added a new mod entry for overwrite_min_cycle_recoil and a helper for items to take the guns cycle recoil or a mod if there is one.
Describe alternatives you've considered
Testing
Additional context