Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permanent effect default duration #54957

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Jan 31, 2022

Summary

None

Purpose of change

Fixes #53929

Describe the solution

Make permanent effects duration default to 1 turn instead of 0 as 0 turn effects never happen.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 31, 2022
@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Effects / Skills / Stats Effects / Skills / Stats NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Jan 31, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 31, 2022
@ZhilkinSerg
Copy link
Contributor

Yeah, there was a comment about that - cff3ba5#r57332628

@ZhilkinSerg ZhilkinSerg merged commit c792873 into CleverRaven:master Jan 31, 2022
@Ramza13 Ramza13 deleted the effect_fix branch January 31, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions Mechanics: Effects / Skills / Stats Effects / Skills / Stats NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable for has prospectus only lasts length of the conversation
3 participants