Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add makeshift cane and crutch items and recipes, add CRUTCH tag to hollow cane #54944

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

ccaviness
Copy link
Contributor

@ccaviness ccaviness commented Jan 30, 2022

Summary

Content "Add makeshift walking cane and crutch items and recipes, add CRUTCH tag to hollow cane"

Purpose of change

With a broken leg, the player has no way to craft a cane or crutch. The existing cane and crutch are only available via random drops. The hollow cane does not have the CRUTCH tag so cannot be used as a crutch.

Describe the solution

Add makeshift walking cane and makeshift crutch items and recipes so a player can craft a CRUTCH. Add the CRUTCH tag to the existing hollow cane item as well.

Testing

Started new character, verified new items were available to be crafted. Broke leg via debug, and verified that the new makeshift walking cane, makeshift crutch, and existing hollow cane all worked a a crutch when wielded.

Additional context

I made guesses here for the recipes and item stats. The makeshift cane and makeshift crutch items were mostly copied from the walking cane and crutch items, but with debuffed stats. I'm not sure if these are properly chosen, though. The added recipes were also guesses based on some other similar recipes.

With a broken leg, the player has no way to craft a cane or crutch. The existing cane and ccrutch are only available via random drops. The hollow cane does not have the `CRUTCH` tag so cannot be used as a crutch.
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 30, 2022
@Maleclypse Maleclypse added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 30, 2022
Co-authored-by: Binrui Dong <[email protected]>
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 30, 2022
@kevingranade kevingranade merged commit b002ef1 into CleverRaven:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants