Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add looks_like to bottle_bathroom #54942

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

Faalagorn
Copy link
Contributor

Summary

None

Purpose of change

#51885 added more bathroom items including shampoo bottle. This is to provide a placeholder for tilesets that don't have correct sprites yet. This stemmed from discussion in Cataclysm Tileset Project about plastic bottles having no images, which turned to be plastic bottles out of the shampoos etc.

Describe the solution

Similar to my #54696 for meth, add looks_like to a regular plastic bottle (which is similar enough and serves a similar purpose, it even have the same ASCII art)

Describe alternatives you've considered

Draw a sprite for an item, there is one ready for Ultica as of writing added on the Cataclysm Tileset Project by a new contributor fvck censorship#1482, thanks! Still having looks_like for other tiles seems to be not a bad idea IMO.

Testing

Compiled the game, it seems to appear correctly. Here's how it looks for Ultica et al. before fvck censorship#1482's bottle will be added.
Before:
screenshot_2022-01-30-170657
After:
screenshot_2022-01-30-173037

Additional context

Add `looks_like` to `bottle_bathroom` so it appears in tilesets as `bottle_plastic`.
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 30, 2022
@BrettDong BrettDong added SDL: Tiles / Sound Tiles visual interface and sounds. [JSON] Changes (can be) made in JSON labels Jan 30, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 30, 2022
@kevingranade kevingranade merged commit 74d20eb into CleverRaven:master Jan 31, 2022
@Faalagorn Faalagorn deleted the patch-4 branch January 31, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants