Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid TOC entry #54800

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Remove invalid TOC entry #54800

merged 1 commit into from
Jan 29, 2022

Conversation

matshou
Copy link
Contributor

@matshou matshou commented Jan 26, 2022

Summary

None

Purpose of change

The document had a Table of Content entry leading to a section that did not exist.

Describe the solution

I've just removed the entry from the Table of Content.

Describe alternatives you've considered

I've considered re-adding the section.

Testing

Additional context

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 26, 2022
@Maleclypse
Copy link
Member

Maleclypse commented Jan 26, 2022

This is gonna sound ridiculous but there must be some project documentation about building using Visual Studio because I had never compiled anything before coming to this project and this project taught me how to compile using Visual Studio. Long story short that means somewhere there is a project doc that would make sense as a section there probably.

edit: It's probably AMurkin's guide and I would suggest we add it if that's possible so if Amurkin ever leaves github that won't vanish into the ether?

@Maleclypse Maleclypse added the [Markdown] Markdown issues and PRs label Jan 26, 2022
@matshou
Copy link
Contributor Author

matshou commented Jan 26, 2022

The documentation about how to compile on Windows using Visual Studio and vcpkg is here. This same document is also linked in COMPILING.md. All I did was remove the TOC entry that was leading to a no longer existing heading.

I learned everything I needed to know to get started with compiling using Visual Studio from the provided link.
Could you provide a link to the guide you are talking about?

@ZhilkinSerg ZhilkinSerg merged commit 540a944 into CleverRaven:master Jan 29, 2022
@matshou matshou deleted the topic/docs branch January 31, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants