Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded Power Armor encumbrance reduction #54764

Merged

Conversation

John-Candlebury
Copy link
Member

@John-Candlebury John-Candlebury commented Jan 25, 2022

Summary

None

Purpose of change

Fix #54722

Describe the solution

Remove the hard coded encumbrance reduction that was automatically granted to active power armors, and a replace them with standard JSON definitions.

As a side effect, the pseudo active qualities of the helmet were removed, and now you have to activate it manually. A small inconvenience compared to before, but I think making them work like our standard tool_armors makes them easier to maintain and expand.

Describe alternatives you've considered

Figuring how to fix this while also keeping the pseudo active helmet.

Testing

Load and test the armors to check if the linked issue was solved.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 25, 2022
@Drew4484
Copy link
Contributor

Nice work!

@John-Candlebury John-Candlebury force-pushed the explicit-pa-encumbrance branch from 681deb7 to 72a8b3f Compare January 25, 2022 13:55
@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 25, 2022
@kevingranade kevingranade merged commit 46bb3f1 into CleverRaven:master Jan 25, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activating & Deactivating Power Armor suits doesnt update encumbrance
4 participants