Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cancel running master builds #54617

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Don't cancel running master builds #54617

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0192007
Don't cancel running master builds
kevingranade Jan 20, 2022
b9920b9
ytho?
kevingranade Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ on:
- master

# We only care about the latest revision of a PR, so cancel all previous instances.
kevingranade marked this conversation as resolved.
Show resolved Hide resolved
# Allow running master builds to complete to help with ccache refreshes.
concurrency:
group: general-build-${{ github.event.pull_request.number || github.ref_name }}
cancel-in-progress: true
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
Copy link
Member

@akrieger akrieger Jan 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My turn to be (un-)professionally embarrassed for not realizing the solution (to have PRs self-cancel but not master) was as easy as this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was stumped for about 10 minutes, you're not alone.


# Overall strategy for what sorts of builds to include:
# We want a build for the newest and oldest supported version of each compiler.
Expand Down