[CR] New Town Hall Variant #54554
[CR] New Town Hall Variant #54554
Conversation
Added four confrence rooms where the classroom was and made some windows bigger for a varient? I want to use a nested map to make it easier to understand later and have less wasted file space. I also still need to hook the varient into mapgen
Adding new Town_Hall Variant Info to other files Should be able to spawn naturally? Also, cleaned up the town hall to remove the redundant roof from the file.
Doesn't fix error but does change a few minor style things.
github-actions
bot
added
the
astyled
Doesn't fix the issue on new character.
|
(I thought I already posted this but I forgot to.) DEBUG : Mapgen town_hall_2_0_0_0 is not used by anything! FUNCTION : void mapgen_factory::check_consistency() |
|
Since you didn't change the town hall too drastically, I think duplicating the entire building is a bit overkill. If you only want to make a variant of one om_terrain, you could take advantage of the weight system and assign two mapgens on the same overmap terrain. That way, you wouldn't have to edit regional_map_settings.json, multitile_city_buildings.json, and overmap_terrain_public_institutional.json. Btw, nice addition! |
|
@LovamKicsiGazsii I am not exactly sure how to do that? My biggest change is the the second story but I had small changes to the first floor. I thought about trying to split up the given map so that I only had to include the changed sections. But, I couldn't even get it to work together. And If I cut it out at the wrong point it would probably mess it up. It still doesn't work. Not sure why it crashes? I can't figure out why? |
|
I did some checking and apparently there aren't any crashes on the newest experimental version and it can be debug spawned properly but it doesn't seem to naturally occur at normal spawn rates. Although, maybe I was just unlucky? Since when I ramped up the spawn rate to a higher level it spawned without error. DEBUG : loading non-main map at (462,610,0) which overlaps with main map (abs_sub = (459,607,0)) is not supported FUNCTION : void map::load(const tripoint_abs_sm&, bool, bool) After some more testing I am pretty sure it's a local issue. Since someone else tested it and it didn't occur for them? Or maybe it's an OS specific issue that has nothing to do with this? |
JonathanLochridge
changed the title
Summary
Content "New Town Hall Variant"
Purpose of change
I thought having more town hall variants would be nice. Also that it might be a relatively easy thing to change for a first location change.
Describe the solution
Changed the classroom on floor 2 to a set of conference rooms.
Made the windows more symmetrical.
Describe alternatives you've considered
-A variant with an included small library.
-A variant with an attached greenspace and parking lot.
Testing
All files Linted.
New variant can spawn in latest experimental when these files are added.
Error occurs on startup but I think it is unrelated to the new variant.
Additional context
It could have some minor items added to the new room. Trying to figure out how to do that. Now that I got it to spawn properly I should work on that and adding it to the start location for the town hall on my next pass after this PR.
Functional