Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baseball recipe #54384

Merged
merged 5 commits into from
Jan 15, 2022
Merged

Conversation

juliavetter
Copy link
Contributor

@juliavetter juliavetter commented Jan 14, 2022

Summary

Balance "Add baseball recipe"

Purpose of change

In innawood, there was no way to use the dodging practice recipe, since you need some kind of ball. A baseball seems easy enough to craft that this could be added to mainline as well.

Describe the solution

I added a recipe to craft a baseball from leather, strings, and glue. This can be used to practice dodging (or as a thrown weapon).

Describe alternatives you've considered

Testing

Started the game, confirmed the baseball can be crafted with the specified components and then disassembled.

Additional context

The recipe requires fabric cutting 1, which is not available innawood until you get metal working, which makes the recipe not so useful. But a pre-metal fabric cutting item may be added in the future.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 14, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 14, 2022
@juliavetter
Copy link
Contributor Author

juliavetter commented Jan 14, 2022

Test failures seem unrelated I think? And all tests are successful when I run them from my end.

@kevingranade
Copy link
Member

Just a FYI as I'm not the realism police for mods, you're pretty heavily under representing the amount of string in a baseball.
https://bluemonkeysports.com/how-much-string-is-in-a-baseball/
tl;dr 369 yards

@juliavetter
Copy link
Contributor Author

tl;dr 369 yards

!! I was just going off the existing disassembly recipe for baseballs. 369 yards is around 185 long strings/cordages. WIth cordages that would probably be doable, if wildly inefficient. But with strings, it would take a few weeks of constantly dissasembling fibrous stalks to get that much string. May have to rethink this one...

@Light-Wave
Copy link
Contributor

I much appreciate your input, @kevingranade
A baseball in-game weight 0.33 lbs. A long string weight 0.08 lbs. 185 long strings would weight 14.8 lbs, or almost 45 baseballs. A baseball made entirely of long strings would be made out of 4.125 long strings. Perhaps the string used in real balls is thinner than what we are using in game?
2 to 3 long strings sounds like a reasonable amount in my opinion.

@kevingranade
Copy link
Member

If I had to guess I'd say the string recovered in the disassembly recipe represents the stitching as that's heavy duty twine, where the filling is a lightweight yarn. The person that made the recipe might have not known about the filling or discounted it as not useful and just had it recovering the covering.

My best guess at how much string to use for filling is to ignore the length and just look at weight, the string item we use is a relatively thick/heavy twine, but that means it's going to take up more space too. It's not going to be an "official MDB basebal", but for the purposes of the game it doesn't matter. With that adjustment you could feel free to push it to the main game if you like.

Potentially the disassembly recipe should yield a similarly matched weight of fiber instead of huge amounts of string, but that's very much a side issue.

@juliavetter juliavetter changed the title [Innawood] Add baseball recipe Add baseball recipe Jan 15, 2022
@juliavetter
Copy link
Contributor Author

Ok, (after struggling with git) I have changed the recipe to instead use 3 long strings/cordage according to feedback from @Light-Wave and @kevingranade, and moved this change into mainline instead of just innawood. I also removed the existing uncraft recipe, so that now it gives properly 3 long strings instead of 2 short strings.

@Rivet-the-Zombie Rivet-the-Zombie merged commit f1997bf into CleverRaven:master Jan 15, 2022
@NetSysFire NetSysFire added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Jan 15, 2022
@juliavetter juliavetter deleted the baseball-innawoods branch January 15, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants