-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baseball recipe #54384
Add baseball recipe #54384
Conversation
Test failures seem unrelated I think? And all tests are successful when I run them from my end. |
Just a FYI as I'm not the realism police for mods, you're pretty heavily under representing the amount of string in a baseball. |
!! I was just going off the existing disassembly recipe for baseballs. 369 yards is around 185 long strings/cordages. WIth cordages that would probably be doable, if wildly inefficient. But with strings, it would take a few weeks of constantly dissasembling fibrous stalks to get that much string. May have to rethink this one... |
I much appreciate your input, @kevingranade |
If I had to guess I'd say the string recovered in the disassembly recipe represents the stitching as that's heavy duty twine, where the filling is a lightweight yarn. The person that made the recipe might have not known about the filling or discounted it as not useful and just had it recovering the covering. My best guess at how much string to use for filling is to ignore the length and just look at weight, the string item we use is a relatively thick/heavy twine, but that means it's going to take up more space too. It's not going to be an "official MDB basebal", but for the purposes of the game it doesn't matter. With that adjustment you could feel free to push it to the main game if you like. Potentially the disassembly recipe should yield a similarly matched weight of fiber instead of huge amounts of string, but that's very much a side issue. |
Ok, (after struggling with git) I have changed the recipe to instead use 3 long strings/cordage according to feedback from @Light-Wave and @kevingranade, and moved this change into mainline instead of just innawood. I also removed the existing uncraft recipe, so that now it gives properly 3 long strings instead of 2 short strings. |
Summary
Balance "Add baseball recipe"
Purpose of change
In innawood, there was no way to use the dodging practice recipe, since you need some kind of ball. A baseball seems easy enough to craft that this could be added to mainline as well.
Describe the solution
I added a recipe to craft a baseball from leather, strings, and glue. This can be used to practice dodging (or as a thrown weapon).
Describe alternatives you've considered
Testing
Started the game, confirmed the baseball can be crafted with the specified components and then disassembled.
Additional context
The recipe requires fabric cutting 1, which is not available innawood until you get metal working, which makes the recipe not so useful. But a pre-metal fabric cutting item may be added in the future.