Split up sidebar.json roughly by widget_var #54125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To facilitate future expansion in widget styles for each widget_var, break up the main sidebar.json file into pieces: - activity.json, body_temp.json, date.json, encumbrance.json, etc. - layout.json: Various layouts combining other widgets - sidebar.json: Main sidebar definition(s) only
wapcaplet
force-pushed
the
w-widget-splinter
branch
from
146ba9e to
b056050
Compare
wapcaplet
added
the
Info / User Interface
github-actions
bot
added
astyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
To facilitate future expansion in widget styles for each
widget_var, and to take better advantage of this wholedata/json/uidirectory dedicated to widgets.Describe the solution
Break up the main
data/json/ui/sidebar.jsonfile into pieces:widget_var, but close enoughDescribe alternatives you've considered
I realize that large reorganizations like this are generally unwelcome due to the churn they generate, but I wish I had set a better precedent in the layout of this directory in the first place. I figured better to churn now, while it's still early in its maturity.
Testing
Additional context