Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update materials density #53908

Closed
wants to merge 1 commit into from

Conversation

Drew4484
Copy link
Contributor

Summary

Content "Update material density"

Purpose of change

Values are inaccurate in most cases. Material density apparently only matters for vehicle collisions, but should be as accurate as possible in case it is used in more cases going forward.

Describe the solution

First pass of updating density. Some don't have an obvious answer (like ballistic glass), others aren't real (hyperweave).

Describe alternatives you've considered

Adding more materials with incorrect density as part of other PRs.

Testing

Additional context

First pass, stopped at Human Flesh. Some have been passed over (ballistic glass, hyperweave) when there isn't an obvious answer.

First pass of updating density. Some don't have an obvious answer (like ballistic glass), others aren't real (hyperweave).
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Dec 30, 2021
@Maleclypse Maleclypse added the [JSON] Changes (can be) made in JSON label Dec 31, 2021
@NetSysFire NetSysFire added the Items / Item Actions / Item Qualities Items and how they work and interact label Jan 1, 2022
@anothersimulacrum
Copy link
Member

Can I suggest we just remove this, and add something if we need it? As far as I have seen, it's a useless and poorly unit-ed property that just makes doing things with materials harder.

@Drew4484
Copy link
Contributor Author

Drew4484 commented Jan 1, 2022

Can I suggest we just remove this, and add something if we need it? As far as I have seen, it's a useless and poorly unit-ed property that just makes doing things with materials harder.

As in remove from all non-vehicle parts, or remove entirely?

@anothersimulacrum
Copy link
Member

Remove it entirely.

@Drew4484 Drew4484 closed this Jan 13, 2022
@Drew4484 Drew4484 deleted the Material-density branch January 13, 2022 20:57
@drhead drhead mentioned this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants