Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extra space from layering menu #53905

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

CosmicHitman
Copy link
Contributor

Summary

Bugfixes "Remove duplicate space in clothing layering menu"

Purpose of change

Weep no more, but rejoice! The vile extra space has been purged from the clothing layering menu when a survivor is wearing conflicting clothes. No more will it trouble us. Fixes #53823

Describe the solution

Previously, the string specifying the layer had spaces at the end. Unfortunately, it was being inserted into a string that put a space on both sides of the insertion point which resulted in duplication. So I just removed the spaces from the layer string. This should be fine as this is the only spot those strings are used anyway.

Describe alternatives you've considered

Continue to let the extra space stay, and the tears from seeing it flow.

Testing

Step 1: New world, new character.
Step 2: Wear extra shirts, pants, bags, etc to have conflicting clothing layers.
Step 3: Check in the clothing layering menu and see the lone space between the layer and the word "on".

Additional context

image
The lone space shown on a heavily overdressed survivor.

As a side note, I noticed when wearing a t-shirt and long sleeved shirt at the same time the body part name in the layering menu is blank (both before and after this change). This is probably not intended, but I would prefer to double check before submitting an issue. Sadly, I could not find the root of the problem myself.
image
Empty body part.

Because two spaces are not needed.
fixes CleverRaven#53823
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 30, 2021
@bombasticSlacks
Copy link
Contributor

bombasticSlacks commented Dec 31, 2021

This is probably not intended, but I would prefer to double check before submitting an issue. Sadly, I could not find the root of the problem myself.

You and me both.

#53459

Also thanks for doing this!

@NetSysFire NetSysFire added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Jan 1, 2022
@kevingranade kevingranade merged commit c8defa5 into CleverRaven:master Jan 1, 2022
@CosmicHitman CosmicHitman deleted the sort_armor_space branch January 1, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra space in Sort Armor menu's "multiple items are adding encumbrance" message
5 participants