Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend vehicle parts repair requirements #53854

Merged
merged 3 commits into from
Dec 30, 2021

Conversation

Alex-Folts
Copy link
Contributor

Summary

Balance "Changes and updates for repair requirements of vehicle parts"

Purpose of change

Recently were separated welding requirements for installation and repair(additional tools and components) of vehicle parts. With this PR all entries of "welding_standard" replaced with "repair_welding_standard" for repairs.

Additionally was applied some suggestions from #42832

Describe the solution

  • I examined all vehicle parts, replaced "welding_standard" with "repair_welding_standard" where it was required.
  • Additionally changed repair and install cost for some parts.
  • Changed repair/install/remove requirements and tools for some parts to make it more sensible.
  • Added more tools and components for repair engines and motors, now it looks more resonable.
  • Removed repair option for windshields as it was not sensible to repair it with welder, and other available methods make not much sense either.

Describe alternatives you've considered

Total overhaul of repair system, unify item repair system with vehicle repair system.

Testing

Spawned vehicles, check repair, required components, tools, check install/remove parts.

Additional context

About windshields: assuming that windshield is a standard laminated glass, which consist of several layers of glass with thin plastic film inbetween glued all together, if you break it will cover with cracks but will not fall apart and will hold in place.

  • adhesive methods of repair won't make much difference, if you patch it with duct tape it will limit visibility even more, glue won't remove cracks and won't recover initial strength of a glass
  • repair with welder make no sense at all
  • acetylene torch can melt glass and sort of weld cracks, but most likely glass will crack in another place due to thermal shock, moreover it will get distorted and deformed.

Considering all above i decided to make windshields non repairable, only replaceable.

-replaced welding_standart with repair_welding_standart for repair
-updated requirements for repair vehicle parts
-added more tools for repair engines and other complex parts
-replaced welding_standard with repair_welding_standard for repairs
-fixed some repair requirements
-fixed few install/remove requirements
-removed repair option for windshields as it is make no sense
@Maleclypse Maleclypse added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Vehicles Vehicles, parts, mechanics & interactions labels Dec 29, 2021
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 29, 2021
@ZhilkinSerg ZhilkinSerg merged commit 441ca01 into CleverRaven:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants