Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPCs - rewrites #53800

Closed
wants to merge 7 commits into from
Closed

NPCs - rewrites #53800

wants to merge 7 commits into from

Conversation

LovamKicsiGazsii
Copy link
Contributor

Summary

Content "godco - make old NPCs up to standard"

Purpose of change

cook.json and foodguard.json were clearly not up to the mark dialogue-wise, especially in comparison with other NPCs. Their dialogue options made it very difficult to navigate from talk topic to talk topic, their speech sounded unnatural and neither of them talked like they were part of a religious organization. The main focus of this PR is to change that.

The secondary aim for this PR is to re-add some of the mapgen changes from #37088. The most important being the expansion of the soccer field, the wheelbarrow and wheelchair, and the SUS_ itemgroups.

Describe the solution

cook.json and foodguard.json were near completely rewritten. All their dialogues were replaced - save for a few sentences - to be more in line with the 3 (relatively) newly added NPCs and with their ranks in the faction as well. They should sound a bit more human thanks to some flavour texts, a more navigatable dialogue tree, actual backgrounds, and generally smoother sounding lines.

For the time being, they were given supernatural levels of night vision to discourage the player from obtaining easy loot.

Describe alternatives you've considered

None.

Testing

Tested spawn, missions, and dialogue trees.

Additional context

godco

And the old campground for comparison.

godco_old

@wapcaplet wapcaplet added [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Dec 28, 2021
@BrettDong
Copy link
Member

Did you disable GitHub Actions in your fork repository? This pull request cannot be merged before the four required tests (basic build, JSON style check, validate PR, and astyle check) passes.

@LovamKicsiGazsii
Copy link
Contributor Author

Did you disable GitHub Actions in your fork repository? This pull request cannot be merged before the four required tests (basic build, JSON style check, validate PR, and astyle check) passes.

All actions are enabled in my repository. I'll close and reopen to see if that kicks it off.

@LovamKicsiGazsii LovamKicsiGazsii deleted the godco-npc-remake branch January 4, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants