-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate overmap specials #53702
Merged
Merged
Migrate overmap specials #53702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseguin
force-pushed
the
migrate_om_specials
branch
from
December 23, 2021 06:27
3d85ebe
to
ff8ace9
Compare
BrettDong
added
<Bugfix>
This is a fix for a bug (or closes open issue)
[C++]
Changes (can be) made in C++. Previously named `Code`
(P2 - High)
High priority (for ex. important bugfixes)
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
labels
Dec 23, 2021
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Dec 24, 2021
Tested OK with my save games (see linked issues). Glad to see these bugs finally resolved! |
wapcaplet
approved these changes
Dec 24, 2021
dseguin
force-pushed
the
migrate_om_specials
branch
from
December 24, 2021 21:59
b0bc7d0
to
9a1afca
Compare
There's an issue with |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
[C++]
Changes (can be) made in C++. Previously named `Code`
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
(P2 - High)
High priority (for ex. important bugfixes)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #53224.
Fixes #53423.
Fixes #51856.
Describe the solution
I've added a new type
"overmap_special_migration"
to handle overmap specials that have been migrated or removed:TODO:
FakeSpecial_
buildingsfromIt turns out it didn't require anything special at all, just non-fake id definitionsovermap_specials::create_building_from
Describe alternatives you've considered
I could leave it at hardcoded exceptions, which would work but not optimal.
Testing
Tested loading saves from the linked issues.
Additional context