Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an oven to the power grid #53648

Merged
merged 47 commits into from
Jan 6, 2022
Merged

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Dec 21, 2021

Summary

content "Adds stationary powered ovens"

Purpose of change

Partially addresses #53647

Describe the solution

Adds a powered oven furniture, made from an oven item that can be obtained by deconstructing oven furniture.
This item works like a hotplate currently. Later, it would be nice to have some things that can't be cooked on a hotplate but can be cooked in an oven, such as bread.

Describe alternatives you've considered

I could copy the whole kitchen suite from the vehicle here, but that would mean not having nicely decorated furniture. Instead I'd like to add an oven property that the vehicle kitchen can't replicate. That won't happen in this PR.

Testing

Loads. Can disconnect an oven, drag it around, and place it as an appliance. Can disassemble the appliance to component parts, but you have to be obscenely strong. Still need to test the appliance itself as a tool, will have to get to it tomorrow.

When plugged in, the oven functions as a hotplate and draws charge from the power grid exactly as you would expect.

Additional context

I'd also like this to serve as an example of how to add a single powered furniture item.

This PR reminded me that we have an outstanding bug that prevents you from deconstructing an item if you can't pick it up. We should fix that, since it will mess with all my lovely appliance plans.

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Items: Battery / UPS Electric power management Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Dec 21, 2021
data/json/furniture_and_terrain/appliances.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/appliances.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/appliances.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/appliances.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/appliances.json Outdated Show resolved Hide resolved
@Maleclypse Maleclypse added the Appliance/Power Grid Anything to do with appliances and power grid label Dec 21, 2021
I-am-Erk and others added 15 commits December 21, 2021 12:29
Parting out the specific components of an oven
Making a separate folder for appliance construction because I think these are going to add up to a lot.
Start adding some craft/uncraft recipes. Will need to add rock_wool_bat item.
will need an appliance repair proficiency
@Inglonias
Copy link
Contributor

Inglonias commented Dec 21, 2021

we have a power grid that works with furniture? Since when?

Oh. Since October. Huh.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Dec 29, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

This is an automated message. Please kindly disregard if you think this is inaccurate.

Automatic spell checking encountered unrecognized words in the following text:

  • dismantled stovetops
  • metal fan blade assemblys

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jan 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

This is an automated message. Please kindly disregard if you think this is inaccurate.

Automatic spell checking encountered unrecognized words in the following text:

  • dismantled stovetops

@kevingranade kevingranade merged commit 4d22129 into CleverRaven:master Jan 6, 2022
@I-am-Erk I-am-Erk deleted the appliances1 branch January 6, 2022 02:37
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 6, 2022
@kevingranade kevingranade mentioned this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Battery / UPS Electric power management [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants