-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an oven to the power grid #53648
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/furniture_and_terrain/appliances.json
I-am-Erk
added
[JSON]
Changes (can be) made in JSON
Items: Battery / UPS
Electric power management
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
labels
Dec 21, 2021
Fris0uman
reviewed
Dec 21, 2021
Maleclypse
added
the
Appliance/Power Grid
Anything to do with appliances and power grid
label
Dec 21, 2021
Co-authored-by: Fris0uman <[email protected]>
Parting out the specific components of an oven
Making a separate folder for appliance construction because I think these are going to add up to a lot.
Start adding some craft/uncraft recipes. Will need to add rock_wool_bat item.
will need an appliance repair proficiency
we have a power grid that works with furniture? Since when? |
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Dec 29, 2021
Musteval
reviewed
Jan 3, 2022
This is an automated message. Please kindly disregard if you think this is inaccurate. Automatic spell checking encountered unrecognized words in the following text:
|
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Jan 5, 2022
This is an automated message. Please kindly disregard if you think this is inaccurate. Automatic spell checking encountered unrecognized words in the following text:
|
Wishbringer
reviewed
Jan 5, 2022
Co-authored-by: Wishbringer <[email protected]>
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jan 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Appliance/Power Grid
Anything to do with appliances and power grid
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
Items: Battery / UPS
Electric power management
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
content "Adds stationary powered ovens"
Purpose of change
Partially addresses #53647
Describe the solution
Adds a powered oven furniture, made from an oven item that can be obtained by deconstructing oven furniture.
This item works like a hotplate currently. Later, it would be nice to have some things that can't be cooked on a hotplate but can be cooked in an oven, such as bread.
Describe alternatives you've considered
I could copy the whole kitchen suite from the vehicle here, but that would mean not having nicely decorated furniture. Instead I'd like to add an oven property that the vehicle kitchen can't replicate. That won't happen in this PR.
Testing
Loads. Can disconnect an oven, drag it around, and place it as an appliance. Can disassemble the appliance to component parts, but you have to be obscenely strong. Still need to test the appliance itself as a tool, will have to get to it tomorrow.
When plugged in, the oven functions as a hotplate and draws charge from the power grid exactly as you would expect.
Additional context
I'd also like this to serve as an example of how to add a single powered furniture item.
This PR reminded me that we have an outstanding bug that prevents you from deconstructing an item if you can't pick it up. We should fix that, since it will mess with all my lovely appliance plans.