Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Striking techniques and martial arts buffs affect all types of physical damage #53208

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Conversation

Hymore246
Copy link
Contributor

Summary

Balance "Striking techniques and martial arts buffs affect all types of physical damage"

Purpose of change

Standardized what types of damage are affected by martial arts techniques and buffs

Describe the solution

There has been some inconsistency on what sort of damage is increased when using martial arts. Some techniques affect all damage while others does not for no reason. To remove confusion and establish some sort of standard, I'm made the following changes.

  1. All martial arts buffs that were affecting damage by a percent (mult_bonus) now apply to all types of damage.
  2. All martial arts buffs with Armor Penetration now apply to all types of damage.
  3. All striking techniques (anything that is not a throw, takedown, grapple, etc) that were affecting damage by a percent will apply to all types of damage.
  4. All striking techniques with Armor Penetration now apply to all types of damage.

Keep in mind that if your weapon/gloves do not have a given damage type, then no damage will be done even with a buff or technique. Zero times anything is still zero.

Additional context

There was a lot of debate on if this change should be made at all. After a lot of thought, I decided that techniques and buffs would improve more than bash damage because martial arts don't just make things stronger without a reason. For example, a Boxer using spiked gloves would do more damage with a punch than a normal person because they have better form and can land an attack in a more vulnerable spot and not because Cross is automatically adds extra bash damage. This applies to weapons too. A trained fighter will do more damage with a sword than an untained person using the exact same weapon because the trained fighter knows how to use the weapon more effectively.

@Maleclypse Maleclypse added Martial Arts Arts, Techniques, weapons and anything touching martial arts. [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. labels Dec 4, 2021
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 4, 2021
@Photoloss
Copy link
Contributor

I agree for unarmed weapons but not for weapon-based martial arts. There's always some ambiguity as to what classifies as part of the weapon skill and what constitutes a martial arts (or weapon-innate) technique instead but something like a murder stroke or thrusting into gaps only really works with specific forms of damage. Sure jamming your cudgel into the armpit will hurt "a bit more" but not to the same degree as stabbing a dagger into someone's lung.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 5, 2021
@Rivet-the-Zombie Rivet-the-Zombie merged commit 3dc1a79 into CleverRaven:master Dec 7, 2021
@kevingranade
Copy link
Member

Feel free to point out specific cases where this has bad outcomes or PR adjustments to make changes, but as Hymore pointed out there does not seem to have been any kind of consistency to the previous status quo, so this is more likely to drive more consistency rather than less.

As a follow up to this, we could consider supporting damage_type: all to collapse these entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Martial Arts Arts, Techniques, weapons and anything touching martial arts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants