Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First aid proficiencies #53048

Merged
merged 12 commits into from
Dec 7, 2021
Merged

Conversation

nexusmrsep
Copy link
Contributor

@nexusmrsep nexusmrsep commented Nov 26, 2021

Summary

Content "First aid proficiencies"

Purpose of change

Introducing first aid proficiencies & low tier practice recipes for healthcare.

Describe the solution

Two proficiencies:

  • First Aid - "You know how to bandage wounds and understand basic principles of wound care."
  • First Aid Expert - "Your extensive field experience in bandaging and wound care is on par with that of a paramedic."

Effects:

  • first-tier is equal to extra 1 level of health care (firstaid) skill in efficiency calculations for bandaging & disinfecting & applying pressure to wounds & examining NPC's wounds
  • second-tier is equal to 2 levels of health care (firstaid) skill in efficiency calculations for bandaging & disinfecting & applying pressure to wounds & examining NPC's wounds
  • both bonuses cumulate for up to +3 extra lvl bonuses
  • each tier upgrades tourniquet efficiency from base 2/3 to 3/4 and 4/5 efficiency of blood loss reduction
  • each tier reduces application time of bandages and disinfectants (cleaning wounds) by half (up to 1/4 of base) (*AFTER AUDIT)
    • application times were audited, so the ridiculously low time required to apply was significantly raised to more sane values

Two recipes:

  • bandaging (beginner) - "Practice bandaging imaginary wounds while making sure your bandage won't fall off during activities."
  • bandaging (advanced) - "Practice bandaging different limbs and less accessible parts of your body using both hands and each of your hands alone."

Both are low tier practice recipes, because in general bandaging has quite limited impact on general health care skill.

New proficiencies were added where applicable to professions and hobbies - especially medical and paramedical ones.

Describe alternatives you've considered

Adding some higher tier recipes using some less then ethical requirements.
@I-am-Erk can you shine some light at the topic and perhaps tell what could be the next step from here? Any ideas for expanding from this, like for example destructive use of 'higher' tier items as saline solution, disinfectant, splints, tourniquets, scalpels and maybe some other fancy lab tools like microscopes etc. to introduce mid to high tier practice recipes?

Testing

Light testing in game. Compiled. Proficiencies visible, applied in hobbies and professions. Trainable via practice recipes. Boost in first aid items quality visible on both tiers, time of application of first aid items reduced on both tiers.

Additional context

Inspired by a Reddit discussion.

@wapcaplet wapcaplet added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mechanics: Effects / Skills / Stats Effects / Skills / Stats [JSON] Changes (can be) made in JSON labels Nov 27, 2021
@Termineitor244
Copy link
Contributor

Perfect! Now we only need mechanics and applied science practice recipes to eliminate the most difficult skill grinds of the game! (Food and Survival still don't have practice recipes, but they are way easier to level up and/or make practice recipes).

Just a little suggestion, but for training to level 3 I would expect to have to train first aid skills in general, not just bandaging, the suggestion of Vormithrax on the reddit thread is good in that sense, just with the problem that it needs a body... Why not train those things in your own body?

@Venera3
Copy link
Member

Venera3 commented Nov 27, 2021

I'd add bandaging as a two-tier proficiency and route the practice through that. Healthcare as a skill governs too disparate things (from NPC diagnostics to making bootleg medication) that bandaging your way up to professional level would feel janky - I am aware that that's how it works now, but it really shouldn't. Not that practicing on make-believe wounds should get you far, but it's probably worth it to close the incentive to self-mutilate and bandage.

@nexusmrsep nexusmrsep marked this pull request as draft November 27, 2021 08:03
@nexusmrsep nexusmrsep changed the title Practice bandaging First aid proficiencies Nov 28, 2021
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 28, 2021
@nexusmrsep
Copy link
Contributor Author

I've updated this PR by adding first aid proficiencies, as suggested. I still need to do some cleanup and testing to ensure quality.

@nexusmrsep nexusmrsep force-pushed the first_aid_practice branch 3 times, most recently from eac1156 to b2343d2 Compare November 28, 2021 20:55
ternary operator fix
recipe proficiencies consistency
@nexusmrsep nexusmrsep marked this pull request as ready for review November 29, 2021 20:06
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 3, 2021
@ISuckM8
Copy link
Contributor

ISuckM8 commented Dec 4, 2021

How many bandages do you have to use to get the proficiencies?

@VoleurVolant
Copy link
Contributor

I would strongly suggest adding training for the first level of first aid proficiency to the Paramedics (mag_firstaid) entry and the second level to the Guide to Advanced Emergency Care (emergency_book) entry in data/json/items/book/firstaid.json. Practice recipes are helpful, and I wouldn't necessarily remove them, but having meaningful resources to learn from makes far more sense to me.

@I-am-Erk
Copy link
Member

I-am-Erk commented Dec 4, 2021

So, I am not super keen on calling this "first aid". That's too general. I would suggest we call these "wound care" and "advanced wound care" perhaps, so they might later affect disinfection and stuff but not, for example, airway management. The term first aid makes it hard to tell the difference between the proficiency and the skill, they cover all the same stuff.

Otherwise, I think what you've got here is good, without looking deeply at the code itself. A later proficiency could be related to bone setting and splinting. I don't recall many other things we presently use healthcare for in game.

src/game.cpp Outdated Show resolved Hide resolved
src/game.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Dec 7, 2021
src/character.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 7, 2021
@nexusmrsep
Copy link
Contributor Author

Should the skill 'firstaid' be renamed too?

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 7, 2021
@kevingranade
Copy link
Member

No, the skill firstaid is in fact a catchall for all manner of first aid related activities such as bandaging and pharmacuticals and bonesetting.

@kevingranade kevingranade merged commit db37efe into CleverRaven:master Dec 7, 2021
@nexusmrsep nexusmrsep deleted the first_aid_practice branch December 7, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Effects / Skills / Stats Effects / Skills / Stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants