Implement RUMMAGE_POCKET activity #52975
Conversation
and final touches
wapcaplet
added
<Enhancement / Feature>
github-actions
bot
added
astyled
|
We do want the feature, but before committing to this I want to spend a little time seeing if we can use action queuing instead of having the rummage action be responsible for kicking off the target action. Ideally what happens is you trigger the main action, and then trigger the rummage action, which pushes the main action onto a queue. Once the rummage action is done the main action triggers automatically. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
|
This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it |
Summary
Features "Implement RUMMAGE_POCKET activity"
Purpose of change
This was requested in #40163 . This implementation covers
activating,droping,Eating,Reading,Wearing andwielding actions, both standalone and inside thegame::item_inventory_menu.Describe the solution
This implementation expands on the work of @rsulli55 in PR #40413, adding support for the
activate,drop andEat actions.Describe alternatives you've considered
I didn't.
Testing
I've tested each action in both the standalone hotkey and in the
game::item_inventory_menuhotkeys. I've tested also for items inside multiple containers. As expected, everything worked.One thing that I noticed during testing is that after finishing the action, the moves counter in game shows 0 moves, but the rummage action did use the moves. I don't know how to remedy this though.
Additional context
Pinging @actual-nh because he asked me to do this a long time ago.
Other actions could be added too, like reloading or mending, shouldn't be too difficult.