Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "rummage through container" activity #40163

Open
KorGgenT opened this issue May 5, 2020 · 3 comments
Open

Implement "rummage through container" activity #40163

KorGgenT opened this issue May 5, 2020 · 3 comments
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Items: Containers Things that hold other things (P5 - Long-term) Long-term WIP, may stay on the list for a while.

Comments

@KorGgenT
Copy link
Member

KorGgenT commented May 5, 2020

Is your feature request related to a problem? Please describe.

Right now when you grab something from a container, it just removes the moves immediately. Theoretically it could take half a minute to rummage through a container in particularly unfavorable circumstances, so being able to cancel this action is quite important.

Describe the solution you'd like

Implement a new activity with the new activity actor infrastructure.

Describe alternatives you've considered

none, this is pretty straightforward imo

Additional context

As far as complexity for new features go, this is pretty straightforward. The obtain cost of an item is pretty easy to get if you have the item_location, and the activity doesn't have to do anything until it completes. the activity should start when the player tries to wield, drop, wear, activate, etc. an item from a container that you need to dig out, so it definitely will be an activity the player uses quite often.

@KorGgenT KorGgenT added <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` Items: Containers Things that hold other things labels May 5, 2020
@KorGgenT KorGgenT added this to the 0.F milestone May 16, 2020
@kevingranade kevingranade removed this from the 0.F milestone Dec 14, 2020
@actual-nh
Copy link
Contributor

This should probably be altered by the Disorganized trait. I'm not sure about Packmule - from personal experience, being good at finding places to shove in stuff does not (necessarily!) indicate being good at putting stuff easily accessible places (or for that matter being good at finding it again).

@actual-nh actual-nh added the <Bugfix> This is a fix for a bug (or closes open issue) label Jul 30, 2021
@actual-nh
Copy link
Contributor

@guralub: (Same as Gura on discord?) Interested in tackling this one?

@actual-nh actual-nh added <Bug> This needs to be fixed and removed <Bugfix> This is a fix for a bug (or closes open issue) labels Jul 30, 2021
@wapcaplet wapcaplet removed the <Bug> This needs to be fixed label Nov 19, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Dec 5, 2022
@kevingranade kevingranade added (P5 - Long-term) Long-term WIP, may stay on the list for a while. and removed stale Closed for lack of activity, but still valid. labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Items: Containers Things that hold other things (P5 - Long-term) Long-term WIP, may stay on the list for a while.
Projects
None yet
Development

No branches or pull requests

5 participants
@wapcaplet @kevingranade @KorGgenT @actual-nh and others