Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAGICLYSM] Dragon fixes #52941

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

Terrorforge
Copy link
Contributor

Summary

Bugfixes "Restored missing mutations to the Black Dragon category"

Purpose of change

Due to the awkward organization of the Magiclysm mutation files, several mutations intended to be associated with the Black Dragon mutation category were not accessible. This adds them back.

I also moved a Chimera mutation out of the file meant for black dragon mutations (mutations.json) to the general mutation file (mutation.json, no 's'). I will be moving and renaming these files in a future PR to prevent further confusion like this.

Describe the solution

Instead of doing copy-extend in a separate file, I edited the relevant mutations to directly reference the Black Dragon category and threshold as appropriate.

Describe alternatives you've considered

Testing

Spawned in with a bunch of black dragon serum, used it until I stopped getting mutation. Previously, I would not be getting the various Greater Mana Regeneration etc. mutations, but now I do.

Additional context

I originally submitted these changes as part of #52464, but was asked to split the fixes and the reorganization into separate PRs. This is the first one with just the fixes.

Moving the relevant dragon mutations to other files to avoid duplicates.
"Mutations" is the dragon files, "mutation" (no 's') is the general mutation file.
@wapcaplet wapcaplet added Mods: Magiclysm Anything to do with the Magiclysm mod Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [JSON] Changes (can be) made in JSON labels Nov 21, 2021
@Maleclypse
Copy link
Member

I thought someone had put together a PR to combine the mutation files so that magiclysm stopped having multiple mutation files?

@Terrorforge
Copy link
Contributor Author

I did. Well, I put them in the same folder, reorganized and renamed them. Didn't actually just slam them all together into one file.

But I did that in the same PR where I applied these fixes, and KorGgenT understandably didn't want to try and make sense of both at the same time, so they asked me to split it into two PRs. Trying to fork and submit both at once hurt my brain, so I decided I would just submit this, let it merge, and then deal with the reorganizing.

@Maleclypse
Copy link
Member

That explains my confusion. Thank you!

@KorGgenT KorGgenT merged commit 940c7ae into CleverRaven:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants