Examine contents header and column fix #52854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
A new screen for examining the contents of items was added in #51252. However, display of the header and item list relied on a couple of hackish workarounds in inventory_selector and inventory_column. Those workarounds were cleaned up in #52572, but that PR was focused on the trading UI and resulted in some display issues for inventory_examiner.
Describe the solution
Several related parts of inventory_ui are tweaked to clean up display of inventory_examiner. There should be no impact on any other ui screens.
Describe alternatives you've considered
Fixing item list display:
Fixing header display:
Testing
I set up an inventory with several nested containers, then ensured that each of those containers displayed the header and item list correctly when examining contents.
I also checked before/after for each of the other inventory_selector screens (eat, get, disassemble, etc.) and checked to make sure that none of them changed indentation after these changes.
Additional context
Currently, the item list names are improperly truncated:


And when the screen is small, the parent item name in the header is overwritten by the inventory stats:
After these changes, it looks like this:

The item names in the list will still get truncated, but only when they're actually too long:

Since this is a bugfix for something that was just implemented, I figured a changelog entry for it wasn't particularly beneficial and called this a "None" rather than a "Bugfix"