Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vehicle tools using the CABLE_ATTACH action #52510

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

dseguin
Copy link
Member

@dseguin dseguin commented Oct 28, 2021

Summary

None

Purpose of change

Fixes #52482.
A small bug from #51286 was causing vehicle tools with multiple use actions to use the CABLE_ATTACH action instead of the proper tool action.

Describe the solution

Fixed the ordering of the enum inside vehicle::interact_with(), which relies on TOOLS_OFFSET being the last value. Also added a comment to avoid future mishaps.

Describe alternatives you've considered

Testing

  1. Spawn a vehicle with a welding rig
  2. Attempt to use all tool actions
  3. Verify that tool actions correspond to the proper tools

Additional context

@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) Vehicles Vehicles, parts, mechanics & interactions labels Oct 28, 2021
@kevingranade kevingranade merged commit a8083f9 into CleverRaven:master Oct 30, 2021
@dseguin dseguin deleted the fix_veh_use branch November 7, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using certain vehicle utilities (welding, hotplate from chem lab) promts attach cable prompt instead
3 participants