-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make more things made out of nylon #52376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I missed the professions tab, hold up. |
BrettDong
reviewed
Oct 21, 2021
Maleclypse
added
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Items / Item Actions / Item Qualities
Items and how they work and interact
Spawn
Creatures, items, vehicles, locations appearing on map
and removed
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
labels
Oct 21, 2021
Co-authored-by: Binrui Dong <[email protected]>
Co-authored-by: Binrui Dong <[email protected]>
Sweet. Don't forget to check the crafting recipes for these |
BrettDong
reviewed
Oct 21, 2021
Co-authored-by: Binrui Dong <[email protected]>
"repairs_like": "jacket_army_modern", | ||
"type": "ARMOR", | ||
"name": { "str_sp": "combat shirt" }, | ||
"description": "An oddly balanced long-sleeved shirt with a thin, moisture wicking torso and thicker arms more appropriate for a jacket. The arms are covered in a camouflage pattern and have two shoulder pockets. It has a pocket for your pen!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either add the pen pocket or change the description 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Items / Item Actions / Item Qualities
Items and how they work and interact
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Adds Combat Shirts and Blouses"
Purpose of change
Combat shirts and Blouses are conspicuously missing from the game, garments which both are designed to be worn with armor (plate carriers and vests). They are made of more modern materials than cotton. In addition, few modern soft tactical gear like pouches and storage gear like backpacks is made of cotton.
Describe the solution
Changes the material where appropriate. Adds the items in question, adjusts spawns to match. Adds the old army jacket to appropriate spawns, adjusts its description.
Describe alternatives you've considered
Not giving the heli pilot anything at all for the outer layer, or adding their weird combo vest/harness thing.
Testing
Loaded the game, made sure no errors came up, and that the stuff was craftable with the right stuff.
Additional context
None.