Support more neighbours in jmapgen_nested #51804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Enhancement / Feature>
BrettDong
reviewed
Sep 23, 2021
Previously only the cardinal directions and above were supported; now all eight horizontal neighbours, above, and below are.
jbytheway
force-pushed
the
diagonal_neighbours_in_mapgen
branch
from
f12a7e7 to
3d4620d
Compare
svenstaro
pushed a commit
to svenstaro/Cataclysm-DDA
that referenced
this pull request
Sep 24, 2021
Previously only the cardinal directions and above were supported; now all eight horizontal neighbours, above, and below are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Support more neighbours in jmapgen_nested for mapgen that depends on diagonal adjacency"
Purpose of change
In some cases to make mapgen work well requires knowing your diagonal neighbours as well as cardinal ones.
Requested by @John-Candlebury.
Describe the solution
Previously only the cardinal directions and above were supported; now all eight horizontal neighbours, above, and below are.
Simplified the implementation of
neighborhood_checkat the same time.Describe alternatives you've considered
Supporting diagonal non-horizontal neighbours too (like
above_north) but I don't think we have a use case for such as yet.Testing
I tweaked the definition of Aftershock's formless ruins to experiment, and it seems to work as expected.
Additional context
@John-Candlebury if you'd like to thank me for this feature, then feel free to write some documentation for the
"neighbours"feature. I don't think there's any mention of it in the docs at all right now.