Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonified dead scientists map extra #51795

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Jsonified dead scientists map extra #51795

merged 1 commit into from
Sep 23, 2021

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Content "Jsonified dead scientists map extra"

Purpose of change

Jsonify hardcoded map extras for ease of reviewing and editing.

Describe the solution

Created a location with several corpses and monsters. Json-version is essentially identical to hardcoded version, with the exceptions:

  • previously there could be at most 3 monsters in the location. Now, depending on rng, monsters could be much more than that.
  • added flesh gibs spawn next to the corpses.
  • removed 10% chance to spawn zombie scientist that could spawn instead of dead scientists' corpses.
  • added one guaranteed spawn of dead scientist corpse with loot.
  • removed rare item group spawn as I think it's inappropriate here.

Describe alternatives you've considered

None.

Testing

Debug-spawned map extra and checked if everything is ok.

Additional context

None.

@Night-Pryanik Night-Pryanik added the Map / Mapgen Overmap, Mapgen, Map extras, Map display label Sep 22, 2021
"terrain": { "1": "t_null" },
"monsters": { " ": { "monster": "GROUP_NETHER_CAPTURED", "chance": 1, "density": 0.0001 } },
"nested": {
" ": { "chunks": [ [ "corpse_blood_gibs_science_3x3", 1 ], [ "null", 150 ] ] },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to double check those chunks are in the game already as I don't see them here and when I searched my local github for corpse_blood_gibs_science_3x3 my search game back with zero responses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This chunk is located in this very file, at the very top.

@Maleclypse Maleclypse self-requested a review September 23, 2021 04:45
@ZhilkinSerg ZhilkinSerg merged commit 81d5927 into CleverRaven:master Sep 23, 2021
@Night-Pryanik Night-Pryanik deleted the jsonify-scientists-map-extra branch September 24, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants