Fix bike shop variant's roof #51729
Merged
Fix bike shop variant's roof #51729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the bike shop variant 1 having an empty roof
Changed stairs down to ladder down
actual-nh
added
<Bugfix>
|
You should add a migration if you are going to change an ID of something already in the maps of players... It causes an error in already started games where the building (with the original ID) is around.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
One of the bike shop variants (s_bike_shop_1) has a ladder going up on the main floor but no ladder on the roof. In fact, it has an empty roof.
You can reproduce it by making a new world, a new character, debug reveal the map and teleporting into several bike shops, the one with the open floor plan has this problem.
Describe the solution
Fixed the small typo on bike_shop.json so the roof is generated properly. Also changed the stairs of the roof into a ladder, like the main floor.
Describe alternatives you've considered
Testing
Made a new character, debug revealed map and teleported into several bike shops, all have normal roofs now.
Additional context
Before the change - empty roof
After the change - normal roof
