Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not being able to fetch tools (disassembly zone) #51343

Merged
merged 2 commits into from
Sep 12, 2021

Conversation

Menschheit
Copy link
Contributor

Summary

None

Purpose of change

  1. One of the variables I defined was overwritten by a local variable during copy&paste.
  2. Should not use default parameter(clear_path = true) in crafting_inventory,
  3. Only the player can do handle_liquid.

Describe the solution

  1. Fix my dumbness.
  2. Add false to the arguments.
  3. Restrict NPCs from the high-end work which they can't deal with.

Describe alternatives you've considered

Testing

Tested with my own save and it worked, but that's not enough I think.

Additional context

If all the items on the same tile have some different unfulfilled requirements, only the last requirement count for fetching action (and it represents the requirements for that tile). So even there are enough (fetchable) tools for other items except the last one, you still can't fetch them.
At the moment I don't have an Idea how to solve the problem without rewriting quite some codes.

@actual-nh actual-nh added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones labels Sep 3, 2021
@kevingranade kevingranade merged commit 5312f48 into CleverRaven:master Sep 12, 2021
Venera3 pushed a commit to Venera3/Cataclysm-DDA that referenced this pull request Sep 21, 2021
* fix fetch required for multi disassemlbe

* NPCs are too dumb to be able to handle liquid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants