Street facing churches #51224
Street facing churches #51224
Conversation
Reverse facing of churches so their entrance faces the street.
|
I just noticed that all the natural ground is generating as dirt instead of grass. I'm fixing that before final PR. |
Missed a comma I should have moved
|
And there's a problem with the roofs now. |
actual-nh
added
<Bugfix>
Roof edges fixed
|
Okay, this is weird. It's failing the JSON validation, but I can't figure out why. It passes the linter and the only changes were in the map grids, which were only rearranged line by line and obviously passed previously. |
Test for fixing JSON validation issue
|
Testing by putting a copy of the original back in to see if THAT passes the JSON validation... |
Checking if the original even passes the JSON validation
Reverting to the fixed version after confirming that original couldn't pass the JSON style check either.
|
Not even the original passes JSON validation for the style check, despite it working perfectly and the linter passing it with zero alterations. It's the checker that's got the bug, not my file. |
|
Still have to fix the groundcover. |
|
Okay, so despite the check failures, all the churches generate with the correct facing and all the staircases line up perfectly. |
|
That sounds like spaces getting transformed into tabs invisibly - including in what you pasted back in. Are you using the web interface or git/equivalent on your machine? The former is, from my own experience, prone to JSON formatting bugs. |
|
I'm just using a browser. I'll check for tabs and non-space blanks with N++. May have to look into getting the Git install. |
All fixed and everything spawns correctly. Let's see if this passes checks.
Seeing if uploading the json as a file solves the check failures.
|
Hmmm... not even uploading the file directly fixes the check issue. Edit: no it wasn't the checker's fault (except that it wouldn't actually point out the EOL error), the file was formatted wrong with CR LF line ends instead of just LF. |
Uploading file with unix EOL formatting
|
Note to all: it was an end of line (EOL) character problem. |
* Street facing churches Reverse facing of churches so their entrance faces the street. * Update church.json Missed a comma I should have moved * Update church.json Roof edges fixed * Update church.json Test for fixing JSON validation issue * Update church.json Checking if the original even passes the JSON validation * Update church.json Reverting to the fixed version after confirming that original couldn't pass the JSON style check either. * Update church.json All fixed and everything spawns correctly. Let's see if this passes checks. * Add files via upload Seeing if uploading the json as a file solves the check failures. * Add files via upload Uploading file with unix EOL formatting * Update church.json to re-initialize the stuck checker Just extended the hedges a bit.
Reverse facing of churches so their entrance faces the street.
Summary
Bugfixes "Fix churches so the entrance is street facing"
Purpose of change
For some reason, the maps for churches had their entrance on the bottom of the map file instead of the top. This causes the game to always draw their entrances on the opposite side they should, given the map layout. This fixes that.
Describe the solution
I simply reversed top and bottom. It's technically a mirror image of the original, but it doesn't matter.
Describe alternatives you've considered
Swapping the left and right sides as well, so it's a true 180° rotation, but it's a lot more work for no significant difference.
Testing
Examined naturally spawned churches, then deliberately spawned a bunch. All face away from the intended direction of rotation. North faces south, east faces west, and so on.
Additional context
All were oriented to face the street in the overmap files, but all face away:
