Fix broken list of languages available #51219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettDong
added
Translation
|
This change seems to break localizations for system installations ( |
Is it still the case after GHC file system merge? |
This comment has been minimized.
This comment has been minimized.
|
Changed to match |
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/translations-not-working-in-release/26944/3 |
Venera3
pushed a commit
to Venera3/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix broken list of languages available"
Purpose of change
The list of available languages was broken after the recent file-system change merge. 7f713d6 is the last good commit. 95975cb is the first commit exhibits the problem.
Only two options, "English" and "System Language", are available for selection. All other languages are missing:
Describe the solution
There is an off-by-one error in extracted language code from directory paths:
Change the language code matching algorithm to only match the
/LC_MESSAGESsuffix so it is now independent of parent directory structure.Describe alternatives you've considered
Testing
The 25 supported languages show up again:
Additional context