JSONize material wind resistance #50739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
[C++]
Cache a variable, use the already fetched maptile to check the terrain at the tile instead of looking up the submap again.
Perform two optimizations on Character::bodytemp 1. Store the items worn on each bodypart, and refer to that instead of iterating through all worn items and selecting the ones for the relevant body part multiple times. 2. Adjust some functions to run once, and return the data for all body parts. This optimization has a fair bit of overlap with CleverRaven#1, but I think both have value There should be no behavioural changes.
Don't check every item for a flag for every item the character is wearing, just check the current flag. Character::in_climate_control drops off the profile of Character::bodytemp with this change.
The vast majority of the time, we won't have any blisters - so only go through the mildly expensive process of getting fire armor when we have blisters.
There's no reason for this to be hardcoded, and dynamically constructing the ids every turn (for Character::update_bodytemp) is actually a significant performance sink. Move it to JSON, experience performance improvements.
anothersimulacrum
force-pushed
the
materials_windresist
branch
from
78ef2ea to
1162d8b
Compare
OrenAudeles
pushed a commit
to OrenAudeles/Cataclysm-DDA
that referenced
this pull request
Sep 16, 2021
Merge pull request CleverRaven#50739 from anothersimulacrum/materials_windresist JSONize material wind resistance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
There's no reason for it be hardcoded, and it's actually a pretty significant performance cost to look up those ids every turn.
Describe the solution
Built on top of #50735
Read the wind resistance of materials from JSON.
Describe alternatives you've considered
cataclysmbnteam/Cataclysm-BN#774 (comment)
Testing
Start a game with Dark Days of the Dead (has really high winds #50375), stand outside in only leather gear, cotton gear, and steel gear, and see different values for cold due to armour material.