cmake: set RELEASE variable to generate install target #50581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Build "Set RELEASE variable in root CMake script based on CMAKE_BUILD_TYPE, to generate install targets"
Purpose of change
The CMake scripts in the
src
anddata
subdirectories generateinstall
targets when aRELEASE
variable is set, but the root script does not define it. Perhaps users are expected to pass this to CMake manually (this is what I've been doing), but to my knowledge this is not documented anywhere.Describe the solution
Set a
RELEASE
variable based onCMAKE_BUILD_TYPE
in the root script.Describe alternatives you've considered
This variable could be removed entirely, and the sub-CMakeLists could check
CMAKE_BUILD_TYPE
directly. I think having a separate variable is more convenient and readable.Testing
Ran CMake with
-DCMAKE_BUILD_TYPE=Release
, the generated Makefile now has a workinginstall
target.Additional context
N/A