Fix dropping worn items from AIM #50452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Bugfix>
BrettDong
approved these changes
Aug 3, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Aug 31, 2021
eltank
pushed a commit
to eltank/Cataclysm-DDA
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #50430
In #50381 I messed up the order in which actions are set and the drop action was never executed, basically preventing dropping worn/inventory items to the ground.
Describe the solution
Reverting #50381 and properly fixing the original problem by setting the exit flag for all if/else branches.
Describe alternatives you've considered
None.
Testing
Tried dropping various items. Regular items are dropped fine, NO_UNWIELD items aren't dropped and don't stack multiple AIM windows on top of each other.
Additional context
Always remember to test thoroughly.