Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vitamins do things #50273

Merged
merged 6 commits into from
Sep 4, 2021
Merged

vitamins do things #50273

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9436275
vitamins do things
dissociativity Jul 28, 2021
aea7488
rate adjustments
dissociativity Jul 28, 2021
f4cf0ff
calcium b gone
dissociativity Jul 28, 2021
630749e
B12 realism
dissociativity Jul 28, 2021
8790951
remove all unlikely deficiencies and excess json lines, max fatigue f…
dissociativity Jul 29, 2021
414e11a
fix commas
dissociativity Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 57 additions & 11 deletions data/json/effects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1955,15 +1955,17 @@
{
"type": "effect_type",
"id": "hypocalcemia",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't Venera3 explain that basically hypocalcemia shouldn't be a thing because it can't devlop in the time frame of the game? #45564 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can comment it out,

Didn't Venera3 explain that basically hypocalcemia shouldn't be a thing because it can't devlop in the time frame of the game? #45564 (comment)

it shouldn't be, your intake should make it not happen unless it happens over many years assuming you eat something with calcium in it every once in while, and the maximum extent for it in this PR, is very mild to medium muscle stiffness, so only low level deficiency, especially given calcium pills exist around the place.

The reason it still exists, but in a very unlikely state, is so drugs that may impact the body's metabolism can make it happen over a more drastic timespan, thus the player has more consequences for their abuse longer-term.

Copy link
Contributor Author

@dissociativity dissociativity Jul 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

300 days of absolutely no intake is astronomically unlikely in a normal gameplay situation, but I don't currently know enough about drugs or injuries to really have a take on how much they'd impact this.

Copy link
Contributor Author

@dissociativity dissociativity Jul 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specifically only implemented mild symptoms for these reasons as well, nerfing my already mild version, though I can probably reduce the speed malus if you think that works better.

"name": [ "Hypocalcemia", "Weak bones", "Brittle bones" ],
"desc": [ "A lack of calcium in your diet will make your bones progressively weaker." ],
"apply_message": "Your bones are becoming more brittle.",
"remove_message": "Your bones regain their usual strength.",
"name": [ "Mild Hypocalcemia", "Hypocalcemia", "Acute Hypocalcemia" ],
"desc": [ "A lack of calcium in your diet will cause various neuromuscular symptoms." ],
"apply_message": "Your muscles are becoming more stiff.",
"remove_message": "Stiffness in your musles passes away.",
"decay_messages": [
[ "Your calcium deficiency is nearly resolved.", "good" ],
[ "Your bones become stronger as your calcium deficiency improves.", "good" ]
[ "Your have better control of your muscles as your calcium deficiency improves.", "good" ]
],
"max_intensity": 3,
"base_mods": { "speed_mod": [ -10 ] },
"scaling_mods": { "dex_mod": [ -1 ], "speed_mod": [ -15 ] },
"rating": "bad",
"blood_analysis_description": "Hypocalcemia"
},
Expand Down Expand Up @@ -2054,21 +2056,45 @@
[ "Your vision improves as your Vitamin A deficiency improves.", "good" ]
],
"max_intensity": 3,
"base_mods": { "per_mod": [ -1 ] },
"scaling_mods": { "per_mod": [ -2 ] },
"rating": "bad",
"blood_analysis_description": "Vitamin A Deficiency"
},
{
"type": "effect_type",
"id": "hypovitB",
"name": [ "B12 deficiency", "Slow healing", "No healing" ],
"desc": [ "A lack of vitamin B12 in your diet will affect your ability to heal." ],
"apply_message": "Simple wounds are starting to concern you more than usual.",
"remove_message": "Your wounds now heal normally.",
"name": [ "B12 deficiency", "B12 anemia", "B12 severe anemia", "B12 dementia" ],
"desc": [
"A lack of vitamin B12 in your diet causes early symptoms of anemia.",
"Prolonged lack of vitamin B12 in your diet causes anemia, loss of taste, problems with focus and fading memory.",
"Severe vitamin B12 deficiency causes bad case of anemia, loss of taste, and damaged memory, causing dementia. Your skills rust."
],
"apply_message": "Your skin is more pale then usual.",
"remove_message": "Your skin tone comes back to its normal color.",
"decay_messages": [
[ "Your vitamin B12 deficiency is starting to resolve.", "good" ],
[ "Your ability to heal returns as your Vitamin B12 deficiency improves.", "good" ]
[ "Your ability to remember things returns as your Vitamin B12 deficiency improves.", "good" ]
],
"max_intensity": 3,
"max_intensity": 4,
"base_mods": {
"fatigue_min": [ 5 ],
"fatigue_max": [ 10 ],
"fatigue_chance": [ 900 ],
"h_mod_min": [ -1 ],
"h_mod_min_val": [ 0 ],
"h_mod_chance": [ 900 ]
},
"scaling_mods": {
"dex_mod": [ -1 ],
"int_mod": [ -0.5 ],
"per_mod": [ -0.5 ],
"str_mod": [ -0.3 ],
"speed_mod": [ -2 ],
"fatigue_chance": [ -100 ],
"h_mod_min": [ -1 ],
"h_mod_chance": [ -200 ]
},
"rating": "bad",
"blood_analysis_description": "Vitamin B Deficiency"
},
Expand All @@ -2084,6 +2110,26 @@
[ "Your scurvy lessens as your Vitamin C deficiency improves.", "good" ]
],
"max_intensity": 3,
"base_mods": {
"pain_max_val": [ 35 ],
"pain_chance": [ 900 ],
"pain_min": [ 1 ],
"pain_max": [ 5 ],
"fatigue_chance": [ 900 ],
"fatigue_min": [ 10 ],
"h_mod_min": [ -1 ],
"h_mod_min_val": [ 0 ],
"h_mod_chance": [ 900 ]
},
"scaling_mods": {
"pain_chance": [ -150 ],
"fatigue_chance": [ -200 ],
"h_mod_min": [ -1 ],
"h_mod_min_val": [ -100 ],
"h_mod_chance": [ -300 ],
"str_mod": [ -0.5 ],
"speed_mod": [ -2 ]
},
"rating": "bad",
"blood_analysis_description": "Scurvy"
},
Expand Down
18 changes: 11 additions & 7 deletions data/json/vitamin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
"type": "vitamin",
"vit_type": "vitamin",
"name": { "str": "Calcium" },
"deficiency": "hypocalcemia",
"min": -12000,
"rate": "15 m",
"rate": "90 m",
"disease": [ [ -4800, -5600 ], [ -5601, -6400 ], [ -6401, -12000 ] ]
},
{
Expand All @@ -17,7 +18,7 @@
"deficiency": "anemia",
"min": -12000,
"max": 3600,
"rate": "15 m",
"rate": "30 m",
"disease": [ [ -4800, -5600 ], [ -5601, -6400 ], [ -6401, -12000 ] ]
},
{
Expand All @@ -26,28 +27,31 @@
"vit_type": "vitamin",
"name": { "str": "Vitamin A" },
"excess": "hypervitaminosis",
"deficiency": "hypovitA",
"min": -8400,
"max": 3600,
"rate": "15 m",
"disease": [ [ -2000, -4800 ], [ -4801, -5600 ], [ -5601, -8400 ] ]
"rate": "180 m",
"disease": [ [ -3000, -4800 ], [ -4801, -5600 ], [ -5601, -8400 ] ]
},
{
"id": "vitB",
"type": "vitamin",
"vit_type": "vitamin",
"name": { "str": "Vitamin B12" },
"deficiency": "hypovitB",
"min": -5600,
"rate": "15 m",
"disease": [ [ -2800, -3600 ], [ -3601, -4400 ], [ -4401, -5600 ] ]
"rate": "180 m",
"disease": [ [ -2800, -3600, 1 ], [ -3601, -4400, 2 ], [ -4401, -5600, 3 ] ]
},
{
"id": "vitC",
"type": "vitamin",
"vit_type": "vitamin",
"name": { "str": "Vitamin C" },
"deficiency": "scurvy",
"min": -5600,
"rate": "15 m",
"disease": [ [ -2800, -3600 ], [ -3601, -4400 ], [ -4401, -5600 ] ]
"disease": [ [ -2800, -3600, 1 ], [ -3601, -4400, 2 ], [ -4401, -5600, 3 ] ]
},
{
"id": "mutant_toxin",
Expand Down