-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supporting infrastructure for first version of migo bio-tech #50178
Conversation
79291d4
to
c522a22
Compare
Co-authored-by: chaohedgehogs <[email protected]>
Co-authored-by: chaohedgehogs <[email protected]>
"id": "EOC_MIGO_BIO_TECH_INTEREST", | ||
"condition": { "not": { "one_in_chance": 3 } }, | ||
"effect": [ | ||
{ "message": "You have a slight feeling of being watched." }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure it should be u_message
, not message
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly what's causing #50590.
…verRaven#50178) * Add ability to store random variable value. * Allow add morale dialog function to use time strings * Add ability to set item name by variable Co-authored-by: chaohedgehogs <[email protected]>
Can 'var' change more than 'name'? Such as' description 'or' use_action'😊 |
No to either. For description, that sounds like a good idea to add eventually, though I don't have a use case in mind right now so it will be pretty low on my to do list. For use_action since with EOCs you can make what an item does change already I'd probably just add a new dialog function if needed. If you have a use case in mind let me know and I'll see what I can do. |
Summary
Infrastructure "Add supporting infrastructure for first version of migo bio-tech"
Purpose of change
Add functionality to json around items using effect_on_conditions.
Give example of use case for talker_item
Describe the solution
This adds a new migo bio tech item, which does not yet spawn anywhere. The infrastructure needed for it to work has also been added.
At present migo bio technology functions as follows:
Upon usage it will choose a type which can be: "morale", "focus", "pain", or "fatigue". It then gives you a bonus of that type.
There is always a chance that a variable called migo interest goes up. At present this does nothing but the plan is to have it eventually trigger mi go attacks.
Included infrastructure features:
Describe alternatives you've considered
Not including the actual migo bio tech item. It's not used yet and still needs better stats and details but it tests the new code and gives a good example of what can be done.
Testing
Additional context