-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Bōjutsu Martial Art #50010
Adds Bōjutsu Martial Art #50010
Conversation
Would probably make sense to add the L-stick to weapons as well? |
Ping: @Hymore246? |
Well, this looks mostly fine for me. Skilled Striking is probably irrelevant since the bash damage cap is rarely an issue - in fact, i am not even sure it stll exists in a meaningful form. Rolling staff is much more problematic - a 25% move cost discount, which is basically always active (It activates when you move, which is when move cost matters anyway) means than you can magically outrun most enemies just by having a quarterstaff in your hands. |
Not sure how it fits with the real life style, but it also feels a bit strange to not have any follow-up techniques to take advantage of stunned/knockdown. I like the defensive block focus though. |
Yeah the intent was for a faster attack not faster movement, but I guess that's just how the game works. Perhaps it would work better as an onPause move?
The IRL style from my knowledge combos from: block -> attack, and possibly into another attack. That final possible attack is represented here by normal attack/another standard technique. |
Makes sense. I wonder if a rapid strike would fit in there for that double-sided action? |
Rolling Staff is now a onPause with 5% less move cost, but +10 Bash Damage.
You could have a fast attack technique that requires the rolling staff buff to trigger. Add some weighting to the technique to make more likely to use it instead of another techniques, and you are fine. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
This has been waiting for a reviewer. I'm putting a note here to myself to review this in the next few days. |
I found this PR yesterday so let me toss in my 2 cents. I agree the style should be in the game. I considered giving staff to Karate in the past (and probably still will) so having a staff style is fine. At a glance, I think this style is overpowered. It is a weapon style that has a lot of damage boosting techniques that do not require any effort to use. The only one that does require a buff is VERY strong, weighted to happen more often, and comes from an OnMove buff that boosts damage even further. Combined with the damage cap remover (which I am not 100% sure we should do, might want to ask a dev) it does a lot of damage. Lastly, it isn't like the style's weapons need the boost either. The Long Stick (weakest weapon) has 18 bash damage and the Ironshod Quarterstaff (strongest weapon) does 32 bash damage. I don't understand how the "damage potential is super high" is a weakness given all these things. Also, being able to stun or knockdown enemies with a counter is VERY good. Good enough that the counters in Dragon Kung Fu and Medieval Swordsmanship have damage penalties to compensate. From my research, Bojutsu is versatile. You can strike a lot of way with a Bo Staff so the style has potential. Here are some thoughts that might help improve the style:
I don't mean to sound negative or dismissive your work. I just want the style to best possible representation of Bojutsu in CDDA. Best of luck! |
Oh, almost forgot. You can probably add a few more pole-like weapons to the style. I think a broom and a mop would make sense for the style. Edit: and maybe the sling staff. I am not 100% if the staff is the right size and quality to use with bojutsu. But if it is most of the community will use your style since they LOVE that weapon. |
I believe that there was a semi-recent PR which made the sling staff and quarterstaff nearly identical in terms of size, the sling staff just has a sling on on one end which makes it slightly heavier and less accurate. Whether or not the presence of a sling makes it unsuited to use with this martial art is a different question. |
Co-authored-by: Termineitor244 <[email protected]>
If someone can rebase this I believe it will be ready for merge. |
This is an automated message. Please kindly disregard if you think this is inaccurate. Automatic spell checking encountered unrecognized words in the following text:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing lack of NPC versions of techniques (i hope thats the error)
Co-authored-by: GuardianDll <[email protected]>
Co-authored-by: GuardianDll <[email protected]>
Summary
Content "Add new Bōjutsu Marital Art"
Purpose of change
Bōjutsu is a real life martial art that could reasonably be learn in the CDDA world.
Describe the solution
Bōjutsu is a martial art that focuses on using the staff or appropriately sized objects.
Bōjutsu Buffs
Bōjutsu Techniques
Rolling Strike buff
Armed opponent
Acceptable weapons:
Long Stick, L-Stick, Long Pole, Quarterstaff, Ironshod Quarterstaff, Powered Quarterstaff
Where the Style Shines:
-Good block Damage reduction
-Pausing gives a good speed and damage boast for 1 turn
-Has a Disarm move
-Feint for Miss Recovery
-Possible bash damage rises with melee skill
New formula: bash weapon damage cap = (2 * (strength + bash skill)) + melee skill
Strength and bash skill still raise the bash weapon damage cap more then the melee skill,
but this allows the style to be used by lower strength characters since the style is more Dex based.
Good in a 1v1 situation.
Where the Style fails:
-No extra blocks/dodges
-No grab break
-Moves that cause a knockdown or a stun are a block counter, but style only has one block.
-Damage potential is not super high, meaning killing higher level creatures could be tough.
Bad when fighting groups or higher level enemies.
Describe alternatives you've considered
Adding a different staff martial art like canne de combat or not adding a staff martial art at all.
Testing
I compiled and ran successfully.
In terms of balance I have no idea if it's too strong or too weak compared to other styles.
Additional context
Finding info about Bōjutsu was tough.
References:
https://www.youtube.com/watch?v=T7xZ4gfsaLc
https://www.youtube.com/watch?v=Rbq-B9aSSQE&t=17s
https://www.youtube.com/watch?v=guLjgsNQC6M&t=740s
https://www.youtube.com/watch?v=W077xpabHNM&t=401s
https://www.youtube.com/watch?v=przR22ApYiM