Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use positional arguments for "It should take %d minutes to finish washing items in the %s." #49997

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

In Polish translation the two arguments %d and %s are reversed in order (Wypranie rzeczy w %s powinno zająć %d minut.), so the translator needs to put positional arguments %2$s and %1$d into the translation, however Transifex rejects it because the original English text is not using positional arguments.

Describe the solution

Use positional arguments in the English text, so Transifex will happily accept translations using positional arguments.

Describe alternatives you've considered

Testing

Additional context

@BrettDong BrettDong added the Translation I18n label Jul 17, 2021
@ZhilkinSerg ZhilkinSerg merged commit 49adfec into master Jul 17, 2021
@BrettDong BrettDong deleted the pos-arg branch July 17, 2021 08:52
@actual-nh actual-nh added 0.F Backport Candidate <Bugfix> This is a fix for a bug (or closes open issue) labels Jul 17, 2021
ZhilkinSerg added a commit to ZhilkinSerg/Cataclysm-DDA that referenced this pull request Aug 12, 2021
ZhilkinSerg added a commit that referenced this pull request Aug 14, 2021
…nutes to finish washing items in the %s.'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants