Add new worn unarmed weapons #49914
Merged
Add new worn unarmed weapons #49914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qrox
reviewed
Jul 13, 2021
actual-nh
added
Crafting / Construction / Recipes
Saelfen
force-pushed
the
Unarmed-weapons-2
branch
from
26e44c5 to
704c48a
Compare
Saelfen
force-pushed
the
Unarmed-weapons-2
branch
2 times, most recently
from
0cc5361 to
a6c8c5c
Compare
Update data/json/items/melee/unarmed_weapons.json Update data/json/items/melee/unarmed_weapons.json astyle monmove even though its unrelated Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
Saelfen
force-pushed
the
Unarmed-weapons-2
branch
from
a6c8c5c to
fbf32e0
Compare
satheon49
pushed a commit
to satheon49/Cataclysm-DDA
that referenced
this pull request
Aug 14, 2021
Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Add Impact and Skewer Knuckles"
Purpose of change
This is a re-PR of #49118. Merge conflicts, as well as converting to the new armor portion format was addressed in this re-PR to make it safe to merge.
Add content to unarmed combat caused by the void left over by #48503. By this point, only 4 unarmed weapons exist in the game. I saw this as an opportunity to use infrastructure added in #41209 for top layer gloves to be used as unarmed weapons to give them a useful niche of their own.
Describe the solution
Create Impact Knuckles and Skewer Knuckles with stats based relative to existing items.
Impact Knuckles has 12 bash (same damage as a pipe), and Skewer Knuckles with 10 pierce ( same damage as a steel sewing awl). From a weapons damage perspective, they are relatively weak combat stat-wise, Impact knuckles being barely stronger than a cudgel which is craftable seconds after starting the game, and Skewer Knuckles being only slightly stronger than a steak knife. This is intentional since unarmed weapons should not be stronger than armed weapons due to leverage and reach.
Describe alternatives you've considered
Not make them at all
Testing
Impact Knuckles:
Skewer Knuckles:
Additional context
Additional changes in this PR:
Moved previously unarmed weapons out of the unarmed json file since they are no longer unarmed weapons.
Removed Bolt cutters from studded gloves since studs do not need bolt cutters to make, only a hammer.