Increased volume and length of western holster to accommodate other revolvers (#48532) #49883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Bugfix>
ghost
deleted the
ZhilkinSerg
added a commit
to ZhilkinSerg/Cataclysm-DDA
that referenced
this pull request
Aug 12, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Aug 14, 2021
…accommodate other revolvers (#48532)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Increased volume and length of western holster to accommodate larger revolvers as expected"
Purpose of change
Fixes #48532 - resized holster to fit classic cap and ball firearms as well as other revolvers.
Describe the solution
Due to the western holster being viewed as a holster for classic six-shooters, I have modified the western holster to hold a volume of 855 ml (large enough for the Lemat revolver) and and length of 38 cm (long enough for the Colt M1860 Army and Lemat).
Describe alternatives you've considered
Reducing the size of the revolvers to fit in the smaller holster, though as discussed in the issue this would require a larger overhaul of the guns themselves.
Testing
Have playtested with the increased holster size and can confirm that Letmat, Colt Army and Colt Navy, S&W 10 and S&W 619 can now all be holstered in the main pocket.