Fix healthy, NPC attack tests #49828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
<Bugfix>
These likely stopped working due to the changes in healthy rounding.
Move the player so game::load_npcs will actually spawn the NPCs. Add REQUIREs to make the game not crash on failing to spawn NPCs. Remove the weather setting because it doesn't change the tests, and causes vision tests failures due to side effects! Adjust the values of the m16a4 test to start passing.
anothersimulacrum
force-pushed
the
tests-fixes
branch
from
7189791 to
0cdf675
Compare
BrettDong
added a commit
that referenced
this pull request
Nov 27, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Make tests pass.
Describe the solution
The healthy tests likely stopped working due to the change in healthy rounding, adjust them to pass.
In the NPC attack tests:
Move the player so game::load_npcs will actually spawn the NPCs.
Add REQUIREs to make the game not crash on failing to spawn NPCs.
Remove the weather setting because it doesn't change the tests, and causes vision tests failures due to side effects!
Adjust the values of the m16a4 test to start passing.
Describe alternatives you've considered
Tracking down the weather stuff more.
Testing
tests/cata_test