Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autonote symbol for derelict shed #49784

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

Valares
Copy link
Contributor

@Valares Valares commented Jul 9, 2021

Summary

None

Purpose of change

The autonote function does not create autonotes for collapsed sheds, although they might be interesting enough for a survivor to take note of. It might also create confusion to find a building in a random place with no corresponding symbol on the map.
Furthermore, the autonote does mark burned ground with a yellow colored point, which isn't really representitive of the remaining ash.

Describe the solution

Added an autonote symbol for the derelict shed map extra: A dark gray ^.
Also changed the color of the burned map tiles to light gray to better represent the ash.

Describe alternatives you've considered

The color gray is a bit tricky to see, and I'm not sure how well it works for people with color vision deficiency, so I've considered other colors instead, but there were none that would really fit. Dark gray is even worse for the burned ground/point, and brown for the shed made it look weird in my opinion.

Testing

Created a new world and verified that the symbol did show up and were the right color.

Additional context

Screenshots of a shed and right below it a burned tile:
Shed_symbol

Added a autonote symbol for the collapsed shed map extra.
Also changed the color of the burned map tiles to better represent the remaining ash.
@actual-nh actual-nh added <Enhancement / Feature> New features, or enhancements on existing Map / Mapgen Overmap, Mapgen, Map extras, Map display [JSON] Changes (can be) made in JSON labels Jul 9, 2021
@pjf
Copy link
Contributor

pjf commented Jul 9, 2021

The color gray is a bit tricky to see, and I'm not sure how well it works for people with color vision deficiency.

Deuteranomaliac here, reporting in that the tile has plenty of contrast for me, because it has extra brightness compared to the surrounding fields.

@Valares
Copy link
Contributor Author

Valares commented Jul 10, 2021

Deuteranomaliac here, reporting in that the tile has plenty of contrast for me [...]

Thank you for reporting in, that's really good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants